#3985 Compute the score to merge PR only from comments after the last commit date
Opened 6 years ago by fbo. Modified 11 months ago

My use case, as a third party tool, is to define if a PR can be merged based on the CI flags and humans comments (score).

In pagure user can add thumbsup and thumbdown to PR's comment and a project's owner can define a minimal score under the one pagure will enable the merge button.

Currently, the score is computed from all the comments but a single commit can bring so much change to a PR. It would be safer to compute the score from the comments added after the commit_start date to be sure reviewers approved the last updated code.


Metadata Update from @pingou:
- Issue tagged with: RFE

6 years ago

Metadata Update from @pingou:
- Issue set to the milestone: 5.6

6 years ago

I'm going to postpone this one as it will require quite some changes on how the score is computed

Metadata Update from @pingou:
- Issue set to the milestone: Coming 3 months (was: 5.6)

6 years ago

Metadata Update from @wombelix:
- Issue set to the milestone: 5.13 (was: Coming 3 months)

2 years ago

Metadata Update from @wombelix:
- Issue set to the milestone: 6.x (was: 5.13)

11 months ago

Log in to comment on this ticket.

Metadata