pagure

#4066 [RFE] Github style CSS block of code and citation
Closed: Fixed Opened by jaruga.

Closed: Fixed
Reopen Issue

I tried below markdown for both GitHub and Pagure.

Markdown sample
https://gist.github.com/junaruga/28efa9c914e0e4e831da47fa4bf6afe0

GitHub
https://github.com/junaruga/github-markdown/blob/master/resources/github_markdown.png

Pagure
https://github.com/junaruga/github-markdown/blob/master/resources/pagure_fedora_markdown.png

I prefer block of code's background color is gray like GitHub.
And right now margin-buttom of the block of code is zero. This is uncomfortable.

Maybe ./pagure/static/pagure.css pre (block of code), blockquote (citation) parts can be better for that.

There is a way to check GitHub CSS.

$ npm install generate-github-markdown-css
$ ./node_modules/.bin/github-markdown-css > github-markdown.css

And here is the sample html I prepare with the GitHub CSS.
https://github.com/junaruga/github-markdown/blob/master/sample.html

This is already fixed in master for 5.2, I believe.

This is how it looks in git currently:

Screenshot_from_2018-11-26_16-03-17.png

Does this suit you?

Thanks for the info. Nice! Gray background color!

But it seems that the latest code of block (pre) is still margin-buttom: 0.
It need space between bottom of the code block and the text "Citation test".

And I think blockquote's padding-top: N and padding-buttom: N is too big comparing with Github markdown html.
Edited by jaruga

GitHub as a reference.
screenshot-github.com-2018.11.21-17-29-02.png

Would you like to work on a PR for this? :)

Well, I get in vacation from tomorrow until Sunday. After coming back, I might look at it. But do not expect it :)

Would you like to work on a PR for this? :)

I can work now for that. Just moment.

I sent PR: https://pagure.io/pagure/pull-request/4069
Please review it.
Thank you.

Commit 3e8c63f1 fixes this issue

Metadata Update from @pingou:
- Issue assigned to jaruga
- Issue set to the milestone: 5.2
- Issue tagged with: RFE
Metadata

RFE

None
None
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.