#662 Emoji do not render in preview
Closed: Fixed None Opened 8 years ago by pingou.

When we preview a comment, emoji such as :wink: do not render. We should fix this :)

For reference, this is the code rendering them:
https://pagure.io/pagure/blob/master/f/pagure/templates/issue.html#_419


I can have a look at this :smile:

I have added the preview for emoji in the comment box ( same as #663).

The emojis are not displayed in the comment text, because the comment text is using a different css class.
The issue description uses '.comment_body' class, where in the reply we use '.comment_text', i have duplicated the code used for rendering the emoji in .comment_body to .comment_text. But I am quite new to jquery.

It might be a better solution . My code is below

https://pagure.io/fork/cverna/pagure/blob/pagure_662/f/pagure/templates/issue.html#_419

Yeah did not see that because my repo was not updated :). I ll just fix the emoji preview.

Thx

Ok, this has been fixed for issues in: https://pagure.io/pagure/pull-request/672

We should just fix it for PR now :)

I guess this is fixed then :)

Thanks @cverna!

Login to comment on this ticket.

Metadata