pagure

#750 Preview of a long comment oveflows the box.
Closed: Fixed Opened by lsedlar.

Closed: Fixed
Reopen Issue

How to replicate:

  • Try to reply to this comment: https://pagure.io/pagure/issue/737#comment-1682
  • Hit Preview button
  • Observe preview spilling over buttons

Snimek_z_2016-02-22_10-04-57.png

Okies, there are two options here to fix --

  1. we can set the overflow of the preview box to scroll, so it scrolls verticalay when longer than the heihgt. or
  2. we can make the preview the whole higght

i am leaning towards #2 here.
Edited by ryanlerch

the second approach sounds good, maybe with a max-height or so and then vertical scrolling? :)

Just submitted a PR for this:
https://pagure.io/pagure/pull-request/758

went with just making the preview box fit the content, as we don't show a scrollbar on a comment when we show it for real, so scrolling the content here seemed a bit strnage.

Commit 78efbe04 fixes this issue
Metadata

easyfix

None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.