#767 Can't create pull request from the master project, invalid link
Closed: Fixed Opened by kparal.

I've forked https://pagure.io/releng. I can create a pull request from my forked project page, that uses this link:

https://pagure.io/fork/kparal/releng/diff/master..feature/fix-phab-links

But when I try to do the same from the releng project page, it uses this link:

https://pagure.io/releng/diff/master..feature/fix-phab-links

That returns HTTP 400 Bad request. It seems it's trying to locate feature/fix-phab-links branch inside the releng repo, but that's incorrect, it's my branch in my forked repo. The UI looks OK when attempting to create such a request, it says File Pull Request -> From kparal/releng feature/fix-phab-links. Just the generated URL is incorrect.


Where did you find the link: https://pagure.io/releng/diff/master..feature/fix-phab-links ?

Currently from a fork you can only open a PR to the main project, we don't (yet) support PR within a fork, so I suspect the first link is/was correct.

testPR.png

This leads to https://pagure.io/releng/diff/master..testPR , while from my fork page it leads to https://pagure.io/fork/kparal/releng/diff/master..testPR .

hm, sounds like a bug indeed

Just submitted a PR that should fix this issue: https://pagure.io/pagure/pull-request/768

Fixed in the PR linked to above

Metadata