#90 Comment/Preview Box needs to be fixed in issues page
Closed: Fixed Opened by subho.

In issues page the comment box needs to be fixed.
The upload.js file is throwing error ,

Uncaught SyntaxError: Unexpected token = 70:312 Uncaught ReferenceError: initDropbox is not defined

Which is causing the trouble.


How do you reproduce this one?

@pingou , Here's a screenshot

This is odd, I do not have this problem. It looks like it's missing a file or so.
Could you try a ctrl+shift+r to clear the cache or so ?

Could you check also if you're not hitting an error to load a file ?

Thanks

Hi @pingou , I tried clearing the cache but still its the same. Not sure why its not occurring on your side.

I looked into upload.js line#107
function initDropbox(csrf_token, id, upload=true) {

upload=true is invalid in javascript syntax.
We can do something like this for setting default value to parameter.
stackoverflow

@pingou, On further searching, link
This seems valid but only in Firefox. I was using Google Chrome. I opened in Firefox and the page loaded fine.

On Wed, Apr 08, 2015 at 03:02:21PM +0000, pagure@pagure.dev.fedoraproject.org wrote:

@pingou, On further searching, link
This seems valid but only in Firefox. I was using Google Chrome. I opened in Firefox and the page loaded fine.

I was just wondering this.
But ok, we should fix this that it works on other browser as well.

Thanks for finding it, do you want to tackle it yourself?

@pingou , sure, assigning the bug to myself. Thanks!

Fixed in http://pagure.dev.fedoraproject.org/pagure/pull-request/92

Metadata