pagure

#1149 Avoid quering issue tracker when it's disabled on the instance
Merged by pingou. Opened by vivekanand1101.
vivekanand1101/pagure pr  into  master

Download 1149.patch

This is not complete yet. The thing is it is able to query and show the options but when you press "Update", the link doesn't get created. It happens only when the issue tracker is turned off on the instance (the change is for that case only)

Forgot to mention, i need a little help. @atelic
Edited by vivekanand1101

You should have pinged @atelic in a new comment, no notifications are sent upon edit :)

@vivekanand1101 It looks like the links don't get created if ENABLE_TICKETS is True even if I remove the atwho code. This might be expected behavior: https://pagure.io/pagure/blob/master/f/pagure/pfmarkdown.py#_175

@pingou Thoughts?

As for the actual code in the PR, it looks good to me. It works and prevents the routing.BuildError :thumbsup:
Edited by atelic

This might be expected behavior: https://pagure.io/pagure/blob/master/f/pagure/pfmarkdown.py#_175

You're right, this if is a little to stringent, we should make it more relax since we now support linking to PR via #

Let's rebase and merge :)

FTR I'm not the most happy w/ the code as it feels a little redundant, but for not that'll do :)

rebased

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.