Fixes https://pagure.io/pagure/issue/1166
So if you're the creator of the group, you can still edit it, even if you were kicked out?
that is if the creator can be kicked out
Which isn't the case: https://pagure.io/pagure/blob/master/f/pagure/lib/init.py#_2526-2528
how about telling wtforms about the maxlength of the fields?
Or just use sa.Text, which has no maxlength.
s/Small/Short/
With the unique constraints, I'm not sure how MySQL/MariaDB will like it (they seems to not like unlimited fields indexed)
Good idea
I'm not seeing a check whether the user is in the group?
It's performed in the lib
Right. This was meant as "either tell wtforms about maxlength or make it so that there is no maxlength" :)
I know it's not ideal since people would be able to access the edit page, but they will not be able to do anything in there.
I went the first way, as you suggested above
One small grammar thing and the maxlength, and then +1.
3 new commits added
+1
Thanks :)
Pull-Request has been merged by pingou
Fixes https://pagure.io/pagure/issue/1166