#1219 Avoid 'Double requirements given' error when using 'pip install -r requirements.txt
Merged by pingou. Opened by vivekanand1101.
vivekanand1101/pagure req  into  master

Download 1219.patch
no initial comment

why not remove this instead?

i thought: what if someone doesn't want local auth but wants to use pagure CI ? then he will either comment/remove those lines particular to local auth.

Lets see what @pingou has to say :smile:

williamjmorenor commented

Yes, I have found this issue a few days ago:

https://pagure.io/fork/williamjmorenor/pagure/c/a3caaa2a56573e1f539f5d5785e863e54a3605b3

rebased

I changed my decision after: https://pagure.io/pagure/pull-request/1214#comment-9025

rebased

Oups, looks like I replied to the wrong issue there.

Thanks for catching it @vivekanand1101

Maybe just add a comment above it to say that it's needed only for local auth or with pagure-ci?

We can then drop the comment when cryptography actually becomes a dep of the core.

rebased

rebased

rebased

Thanks ! :)

Pull-Request has been merged by pingou

Metadata