#1312 Rework milestones
Merged by pingou. Opened by pingou.
rework_milestone  into  master

Download 1312.patch

Instead of relying on tags, milestones are now set for each tickets.
As a consequence, a ticket is can now only be part of one milestone not
multiple as it could before.

This will break projects already using this feature but makes more sense
than relying on tags.

1 new commit added

  • Adjust the documentation about using the roadmap feature

1 new commit added

  • Some more adjustments to the unit-tests for the change when editing an issue

typo here ^^

it's just for my learning: why not just if milestones ?

it's just for my learning: why not just if milestones ?

In this case it's likely just to be consistent with the code above
(in the code above there are case where we need to make the distinction between
foo is None and foo is False).

rebased

1 new commit added

  • Fix the alembic script to drop the milestone column upon downgrade

rebased

'on' is extra. Plus, in the first line of this file, we are saying Pagure allows building the roadmap of the project using the tickets and their tags. . This should be milestones, right ?

although, not related to this PR, this is funny :D

I'm not able to apply patch because of this :/

should't milestones be at the end of parameter list ? In case positional parameter this might create trouble

Add this repo as a new remote and then fetch from it and checkout the branch

yup, good catch

I prefer to keep the options changing the output returned at the end (count returns an int, offset and limit reduce the output returned)

I am confident I'm not using positional arguments with these lasts arguments :)

1 new commit added

  • Fix typos on the roadmap doc pointed out by @vivekanand1101

rebased

Although, i couldn't verify it locally (for a completely unbelievable reason), i have looked at this two more times and i think this should work. so, :thumbsup:

rebased

:thumbsup: after testing locally

Cool, thanks! :)

Pull-Request has been merged by pingou

Metadata