pagure

#1362 Check SSH keys before writing them out
Merged by pingou. Opened by puiterwijk.
puiterwijk/pagure check-ssh-keys  into  master

Download 1362.patch

This is needed because Gitolite will abort all ACL and keyfile regeneration
if there is a single invalid key in its keydir.

Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com

Why assigning the output if we're not going to use it?

ie: why not proc.communicate(key) directly :)

Code wise, just one question.

From an architecture point of view, I was wondering if we should/could group all the method doing system calls into a single module so that we have them all in one place. What do you think?

rebased

rebased

We should really add tests for this but it sure looks good :)

1 new commit added

  • Add test case for SSH key checker

The failed test seems to be a consequence of this change:

File "/srv/jenkins/workspace/pagure/tests/test_pagure_flask_ui_app.py", line 408, in test_user_settings
    'this is my ssh key</textarea>', output.data)

3 new commits added

  • Add test case for SSH key checker
  • Add a validator to check ssh keys on edit
  • Check SSH keys before writing them out

3 new commits added

  • Add test case for SSH key checker
  • Add a validator to check ssh keys on edit
  • Check SSH keys before writing them out

3 new commits added

  • Add test case for SSH key checker
  • Add a validator to check ssh keys on edit
  • Check SSH keys before writing them out

rebased

3 new commits added

  • Add test case for SSH key checker
  • Add a validator to check ssh keys on edit
  • Check SSH keys before writing them out

Could we adjust it rather than removing it?

It tests that the info didn't get lost

rebased

Al right, let's rebase and merge :)

rebased

Thanks! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.