PR#1377: Open a session to the DB for every message received and close it afterward -

pagure

#1377 Open a session to the DB for every message received and close it afterward

Merged Oct 4, 2016 by pingou. Opened Oct 3, 2016 by pingou.

fix_webhook into master

pingou commented Oct 3, 2016

This ensure the data isn't cached and that updating the settings of
a project will be reflected in this service (thus if one updates the
URL, the service will be updated).

Fixes https://pagure.io/pagure/issue/1248

vivekanand1101 commented Oct 3, 2016

:thumbsup:

farhaan commented Oct 3, 2016

Sorry for being silly but can you explain me what exactly is going on ? To be specific why don't we need to cache data here ? why were we doing it previously ? Just being curious :smile:

pingou commented Oct 4, 2016

@farhaan check the ticket linked to in the first comment :)

rebased

Oct 4, 2016

rebased

Oct 4, 2016

farhaan commented Oct 4, 2016

@pingou it makes sense now :smile: works for me :) Thank you for the fix !

rebased

Oct 4, 2016

Pull-Request has been merged by pingou

Oct 4, 2016

Metadata

Assignee

None

Tags

No Tags

pagure

#1377 Open a session to the DB for every message received and close it afterward Merged Oct 4, 2016 by pingou. Opened Oct 3, 2016 by pingou. fix_webhook into master

Metadata

#1377 Open a session to the DB for every message received and close it afterward

Merged Oct 4, 2016 by pingou. Opened Oct 3, 2016 by pingou.

fix_webhook into master