pagure

#1558 Fix clearing the content of a file online
Merged by pingou. Opened by pingou.
fix_edit_file  into  master

Download 1558.patch

As well as setting the branch selected in the form

woaah! what is this ? :P

rebased

They are back :)

Looks good to me :thumbsup:

1 new commit added

  • Add unit-tests for emptying a file online

rebased

Is this the behaviour we want? The file should be there, it's just empty.

I tested this out and got myself into a state where I deleted the content of a file (but not the file itself) and now I can't edit it because when I open the file in the text view it says "No content found in this repository ". When I open it in the raw view, I get this 404. It seems like it should just display all 0 lines of the file.

As this PR doesn't really address this part of the code, I've open https://pagure.io/pagure/issue/1577 to track this issue. Thanks for pointing it out :)

Since this PR doesn't really change an existing behavior, I opened #1577. Are you ok with me merging as is or do you prefer to kill two birds with one stone?

Since it's already there I think it's fine to be an issue. It'll be the same amount of work to adjust now or later, so :thumbsup:

rebased

Thanks! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.