PR#1591: Multiple API fixes - - Pagure.io

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

pagure

#1591 Multiple API fixes

Merged Nov 18, 2016 by pingou. Opened Nov 18, 2016 by pingou.

api_fixes into master

Download 1591.patch

pingou commented Nov 18, 2016

Each commit in this PR can be considered on its own

puiterwijk commented Nov 18, 2016

Awesome!

puiterwijk commented Nov 18, 2016

Are you literally returning "None"? That's invalid json.. :(

pingou commented Nov 18, 2016

Nope, the json is loaded, here this is a dict, thus python, thus null became None

puiterwijk commented Nov 18, 2016

Okay, great. Maybe update the docs to indicate that it's null? :)

1 new commit added

Adjust the API documentation for api_new_issue

Nov 18, 2016

1 new commit added

Support: 'false', '', False, 'False', 0 and '0' as false values

Nov 18, 2016

1 new commit added

Report the form's errors when the input provided doesn't validate it

Nov 18, 2016

rebased

Nov 18, 2016

1 new commit added

Fix running the unit-tests

Nov 18, 2016

puiterwijk commented Nov 18, 2016

Looks sane to me. Thanks!

pingou commented Nov 18, 2016

Thanks!

Pull-Request has been merged by pingou

Nov 18, 2016

Metadata

Assignee

None

Tags

No Tags

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.