PR#1651: Fix the git blame view when the committer has no name -

pagure

#1651 Fix the git blame view when the committer has no name

Merged Dec 9, 2016 by pingou. Opened Dec 8, 2016 by pingou.

fix_blame_authors into master

pingou commented Dec 8, 2016

In the git tree of the linux kernel, the commit febf7ea4bedcd36fba0843db726bba28d22bf89a
has for author Author: <sam@mars.ravnborg.org> which, as you can see,
has no name specified.
This makes pygit2 un-happy and basically makes it crash.

In this commit, we work around the issue by not specifying an user if
the committer did not use one.

vivekanand1101 commented Dec 8, 2016

:thumbsup:

farhaan commented Dec 9, 2016

Just a thought catching Value Error , is it a good practice? Because ValueError can include a lot of other errors too right? Can we not raise a custom exception for this ?

pingou commented Dec 9, 2016

Well, I don't really decide what is raised :) I am catching an exception here, not raising one :)

farhaan commented Dec 9, 2016

hahah Looks good to me then :)

rebased

Dec 9, 2016

Pull-Request has been merged by pingou

Dec 9, 2016

Metadata

Assignee

None

Tags

No Tags

pagure

#1651 Fix the git blame view when the committer has no name Merged Dec 9, 2016 by pingou. Opened Dec 8, 2016 by pingou. fix_blame_authors into master

Metadata

#1651 Fix the git blame view when the committer has no name

Merged Dec 9, 2016 by pingou. Opened Dec 8, 2016 by pingou.

fix_blame_authors into master