This fixes the symptom (the color of the label) not the cause (the close_status is filled while the actual status is Open)

@pingou thanks for pointing it out :)

Maybe this should be where the status is being changed?

Are these changes still needed?

So do you think the list of edited fields should be updated as well?

I am not sure about the purpose for using the "list of edited fields".

I am not sure about the purpose for using the "list of edited fields".

That list is sent in the notifications sent to web-hooks or fedmsg and let people know which field was changed.

So I have a different fix for that same issue that I accidentally run into when trying to fix #1643.

The fix here is flowed btw, the close_status is being changed when the ticket is 'Open' and it is being set to status which is an invalid value for this field.

Therefore I think I will add my fix to my incoming PR, add the tests there as well and close this PR.

I hope you do not mind, if you do let me know and we can re-work this PR to get it working properly :)

I hope you do not mind

Please go ahead ! I really wouldn't have mind if you did it without asking me :)

thanks @rahulbajaj here is my proposition: https://pagure.io/pagure/c/c541632dc6b710ca3e856242942b8a5f5b8c29bd

Going to close this PR then, thanks again for your understanding :)