You can use {# #} for comments in jinja (it will avoid rendering this in the html, cf http://jinja.pocoo.org/docs/dev/templates/ )

I had dropped the 'Goto' iirc

This says it returns 4 items, but I'm seeing 3 items returned line 37 and 38 for example

We could use None instead of "" here no?

Then here we could simply to if attachment[4]"" or to be more robust if attachment[4] is not None

I did not know this download argument, cool :)

Few remarks but pretty straight forward :)

That's because its a sub function (extract_info). So this is correct

Ah indeed, I see the indentation change, cool

New commit has been pushed

Bummer, jinja doesn't seem to like this :(

Investigating

Ok so using none instead of None works, cf http://jinja.pocoo.org/docs/dev/templates/#literals

New commit has been pushed (fixed None to none)

I couldn't get it to work locally, but it misses a > before Comment

Sorry, let me fix this and run the tests

Something happened to my branch and it forced me to do a "git pull", and now its all screwed up. Then I pushed my latest patch, which pulled in a bunch of odd changes. I might have to delete this PR and file a new one...

Looks like there was a rebase but on the wrong branch.

Let's continue on #1676