From 993fd5b714cd02e29285e73a722811f16d934795 Mon Sep 17 00:00:00 2001 From: Vivek Anand Date: Jan 17 2017 10:10:46 +0000 Subject: [PATCH 1/2] Remove unused import in lib/__init__.py : logging --- diff --git a/pagure/lib/__init__.py b/pagure/lib/__init__.py index 29b8264..3808f5f 100644 --- a/pagure/lib/__init__.py +++ b/pagure/lib/__init__.py @@ -21,7 +21,6 @@ except ImportError: import json import datetime -import logging import markdown import os import shutil From 287669d0e74cd755e07827d152846bc3b6315963 Mon Sep 17 00:00:00 2001 From: Vivek Anand Date: Jan 17 2017 10:10:46 +0000 Subject: [PATCH 2/2] Remove unnecessary check for issues in lib/__init__ remove_tags --- diff --git a/pagure/lib/__init__.py b/pagure/lib/__init__.py index 3808f5f..cba4f41 100644 --- a/pagure/lib/__init__.py +++ b/pagure/lib/__init__.py @@ -668,14 +668,13 @@ def remove_tags(session, project, tags, ticketfolder, user): raise pagure.exceptions.PagureException( 'Tags not found: %s' % ', '.join(tags)) - if issues is not None: - for issue in issues: - for issue_tag in issue.tags: - if issue_tag.tag in tags: - tag = issue_tag.tag - session.delete(issue_tag) - pagure.lib.git.update_git( - issue, repo=issue.project, repofolder=ticketfolder) + for issue in issues: + for issue_tag in issue.tags: + if issue_tag.tag in tags: + tag = issue_tag.tag + session.delete(issue_tag) + pagure.lib.git.update_git( + issue, repo=issue.project, repofolder=ticketfolder) pagure.lib.notify.log( project,