pagure

#1806 Fix the web-hook server
Merged by pingou. Opened by pingou.
fix_webhook  into  master

Download 1806.patch

There was several issues in that service that this commit fixes:
- It was trying to access the projet's settings while the session had
been closed and therefore could not be accessed
- It did not take into account not finding the project
- Fix retrieving the username and project name in forks
- It did not take into account project not having web-hook enabled
- Make the request timeout after 60 seconds so that we can move on

rebased

LGTM but, i have question: isn't 60s too much?

Just seeing your comment, 60second could be considered a lot on the other side this will only be a problem with a few services and since we're running an async process I don't think this should be too problematic.

We should monitor the queue though to make sure it doesn't get out of hand and if there is a problem we can then spin off more services.
That being said, monitoring is something that we are currently lacking in most places :(

cool then. :thumbsup:

rebased

Thanks for the review :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.