pagure

#1873 Implement Deploy Keys
Merged by pingou. Opened by puiterwijk.
puiterwijk/pagure deploykeys  into  master

Download 1873.patch
no initial comment

You're no longer check if the output of is_valid_ssh_key is None?
Edited by pingou

Correct. The None result would tell that the user entered newline twice, so there's an empty line, but we already totally ignore those in the code where we write the keys out.

This may end up being quite long, no?

Do we also do that for regular ssh keys?

This is only used for "Regular" (user) ssh keys. We don't use this code for deploy keys, since those are a single key at any time, with no newlines (we reject any deploy keys with newlines).

Yes. But we need to go through them all to make sure we don't add a duped key. I could add a new column to store just this key ID, and just do a query on that if you prefer.

I think that would be faster, especially if we index it

Maybe comment why this one doesn't work?

Could we check the gitolite.conf file produced when there is a pubkey added to the project?

3 new commits added

  • Add tests for deploy keys
  • Add Deploy Keys
  • Make is_valid_ssh_key return key summary

I'm not seeing where this is being called when we create/add a new key (I'm only seeing called when a key is removed)

3 new commits added

  • Add tests for deploy keys
  • Add Deploy Keys
  • Make is_valid_ssh_key return key summary

rebased

indentation looks odd :)

5 new commits added

  • Add Alembic migration for deploy keys
  • Add tests for deploy keys
  • Add Deploy Keys
  • Make is_valid_ssh_key return key summary
  • Fix autogenerating alembic

btw, there are trailing spaces here :)

5 new commits added

  • Add Alembic migration for deploy keys
  • Add tests for deploy keys
  • Add Deploy Keys
  • Make is_valid_ssh_key return key summary
  • Fix autogenerating alembic

5 new commits added

  • Add Alembic migration for deploy keys
  • Add tests for deploy keys
  • Add Deploy Keys
  • Make is_valid_ssh_key return key summary
  • Fix autogenerating alembic

1 new commit added

  • Deploy keys doc

Might need a new line after this one :)

6 new commits added

  • Deploy keys doc
  • Add Alembic migration for deploy keys
  • Add tests for deploy keys
  • Add Deploy Keys
  • Make is_valid_ssh_key return key summary
  • Fix autogenerating alembic

form.ssh_key.data or '' might be needed

6 new commits added

  • Deploy keys doc
  • Add Alembic migration for deploy keys
  • Add tests for deploy keys
  • Add Deploy Keys
  • Make is_valid_ssh_key return key summary
  • Fix autogenerating alembic

It's looking good to me :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.