i think you need to adjust the spaces :) and i am not sure what >> means in the starting of the line.

You might want to fix your spaces here too :)

Looks reasonable to me.

Needs a rebase:

• git checkout master
• git pull upstream master
• git checkout cancel-button
• git rebase master

@farhaan or simply: git pull --rebase upstream master in the feature branch

The message of the second commit is invalid, it needs to reflect what was actually changed.

Seeing the size of the change I would recommend squashing the two commits together but at least the second commit message needs to be adjusted :)

The message of the second commit is invalid, it needs to reflect what was actually changed.
Seeing the size of the change I would recommend squashing the two commits together but at least the second commit message needs to be adjusted :)

I squashed the two commits together :)

This was looking good, any reason to have closed it?

Although, maybe we could do that in one line, see the template: pagure/templates/user_settings.html and search history.back in it :)

I couldnot understand why the build failed. :(

That's because jenkins failed to connect to faitout (http://faitout.fedorainfracloud.org/) to get a postgresql database so it's not related to your change :)

Ohh.. So what do I do now? Can you please help?

Let's just open a new PR to make things easier, but please see my comment above :)

Okay :)