PR#2009: api/issues.py: Rework logic of 'since' -

pagure

#2009 api/issues.py: Rework logic of 'since'

Merged Mar 14, 2017 by pingou. Opened Feb 28, 2017 by vivekanand1101.

vivekanand1101/pagure api_issues into master

Download 2009.patch

vivekanand1101 commented Feb 28, 2017

Fixes: #2007

pingou commented Feb 28, 2017

unit-tests?

rebased

Mar 5, 2017

rebased

Mar 6, 2017

pingou commented Mar 6, 2017

With hard-coding the dates like this, I'm not sure this will remain working over time

vivekanand1101 commented Mar 6, 2017

Example on how should i test this?

pingou commented Mar 6, 2017

Save the date object for example just before creating the ticket.

You also may want to introduce a couple of time.sleep(1) to be sure there is an effective time difference

vivekanand1101 commented Mar 6, 2017

cool, I will update.

pingou commented Mar 13, 2017

Need help w/ this one?

rebased

Mar 13, 2017

pingou commented Mar 13, 2017

Rebased, going to adjust the tests :)

1 new commit added

Adjust the unit-tests to not hard-code the date

Mar 13, 2017

1 new commit added

Rework the unit-tests to test just the desired feature

Mar 13, 2017

vivekanand1101 commented Mar 13, 2017

:thumbsup:

rebased

Mar 14, 2017

pingou commented Mar 14, 2017

Jenkins is happy and so are we \ó/

Pull-Request has been merged by pingou

Mar 14, 2017

Metadata

Assignee

None

Tags

No Tags

pagure

#2009 api/issues.py: Rework logic of 'since' Merged Mar 14, 2017 by pingou. Opened Feb 28, 2017 by vivekanand1101. vivekanand1101/pagure api_issues into master

Metadata

#2009 api/issues.py: Rework logic of 'since'

Merged Mar 14, 2017 by pingou. Opened Feb 28, 2017 by vivekanand1101.

vivekanand1101/pagure api_issues into master