Fixes: https://pagure.io/pagure/issue/2095
While good code wise, this change breaks the unit-tests, could you look at fixing them?
I'm lost in that test output, I changed subject string in lib.notify but tests are failing everywhere
lib.notify
Jenkins is failing for another reasons, if you run the test locally with ./runtests.sh it will tell you which tests are failing.
./runtests.sh
You can use ./runtests.sh -x to make it stop at the first failure.
./runtests.sh -x
Note: there is one test that is fixed in #2118 and isn't related to your change.
rebased
Looks good, please rebase one more time and ping me so I make sure to merge your PR before another one :)
Thanks :)
Pull-Request has been merged by pingou
Fixes: https://pagure.io/pagure/issue/2095