#2219 Add the ability to query for the repo users and groups through the API
Merged by pingou. Opened by mprahl.
Unknown source master

Download 2219.patch

This PR is broken into two commits. The first commit is restructuring existing code so that it can be reused. The second commit actually adds the additional data to the Project GET API.

This PR will allow us to see who has access on a particular Pagure project/repo from the REST API, which is one of the steps to decommissioning PkgDB.

Was there a specific reason for moving from " to ' ?
Otherwise, I think I would have kept the " there, as it makes it easier to print output.data and copy/paste it.

From a first look this looks great (though it seems to conflict), I'll try to review it soon :)

rebased

@pingou thanks! I reverted back to double quotes and rebased. I'm just waiting for Jenkins to run the tests again.

pretty please pagure-ci rebuild

pretty please pagure-ci rebuild

Ok, so the failure don't seem related to jenkins anymore.

I'll have to run the test suite locally to see if it's this PR or something else that's breaking them.

Alright, running the tests are also failing locally, could you look into it?

rebased

pretty please pagure-ci rebuild

1 new commit added

  • Workaround for inconsistent ordering in test

pretty please pagure-ci rebuild

@pingou I got the tests to pass in Jenkins now. Thanks for reviewing!

hm, I think we will want to fix the ordering rather than duplicating the content of the file.

Took me some time but I think I found a solution to make the ordering consistent :)
https://pagure.io/pagure/pull-request/2227

rebased

@pingou I rebased on master and dropped the last commit with the work around. Thanks for your help.

Thank you :)

Pull-Request has been merged by pingou

Metadata