1 new commit added
11 new commits added
If you use # noqa: E402 it'll ignore the fact that the import isn't at the top of the file, but you'll still get a warning when the import is no longer used.
# noqa: E402
PEP-8 imports should be in three groups with a blank line between each: stdlib, 3rd party, local app/library.
I prefer to put from ... import imports above import ..., but I don't think it really matters.
from ... import
import ...
I'm not sure what's getting ignored here, but it'd be better to ignore the one error code that's causing problems if it's not fixable.
Good one :)
I tend to follow that, but I often introduce a blank line between the import and the from ... import (which I prefer after the import ^^)
import
IIRC it was something in the indentation in the docstring, I'll look at it again
Generally looks good, but I recommend adding the specific errors you want to ignore to the # noqa statements, especially the imports so it'll still catch unused imports.
# noqa
:thumbsup:
So it was E501, line to long :)
I've adjusted the # noqa to be more specific.
2 new commits added
Since jenkins is finally passing, I'm going to merge this.
Thanks for your review @jcline !
Pull-Request has been merged by pingou