#2267 Increase unit-tests coverage and bring to 100% pagure/lib/__init__.py
Merged by pingou. Opened by pingou.
unit_tests  into  master

Download 2267.patch
no initial comment

This looks cut off.

to make testing it easier :D

1 new commit added

  • Fix the docstring

This looks good to me. Despite the tests failing in Jenkins, they pass on my machine.

I'll re-run the tests against a local faitout before merging this to see if the behavior differs in sqlite vs postgresql

That could be it, because I'm running it locally with sqlite.

rebased

1 new commit added

  • Make the tests pass on postgresql

19 new commits added

  • Make the tests pass on postgresql
  • Fix the docstring
  • fixup: Simplify checking if the priority is in the list of allowed priorities when creating issue
  • Bring the pagure.lib coverage to 100%
  • Adjust the behavior of search_token when not ACLs are specified
  • Drop un-needed check for user_obj
  • Catch all unicode related exceptions in could_be_text()
  • Move the markdown processor convert call to its own function for easier testing
  • Fix searching issues with an offset of 0
  • Fix filtering issues with tags
  • Only announce user's settings change if there was an error
  • Simplify checking if the priority is in the list of allowed priorities when creating issue
  • Fix creating the group when adding it to a project
  • If the user has no public ssh key and we're trying to install one: bail
  • Ignore some lines we can't really test
  • Add ordering to some of the relations so it returns stable output
  • Simpler is better
  • In one test run we can't cover both postgresql and other, so ignore all
  • Fix running the tests with the perfplugin but without messing coverage

19 new commits added

  • Make the tests pass on postgresql
  • Fix the docstring
  • fixup: Simplify checking if the priority is in the list of allowed priorities when creating issue
  • Bring the pagure.lib coverage to 100%
  • Adjust the behavior of search_token when not ACLs are specified
  • Drop un-needed check for user_obj
  • Catch all unicode related exceptions in could_be_text()
  • Move the markdown processor convert call to its own function for easier testing
  • Fix searching issues with an offset of 0
  • Fix filtering issues with tags
  • Only announce user's settings change if there was an error
  • Simplify checking if the priority is in the list of allowed priorities when creating issue
  • Fix creating the group when adding it to a project
  • If the user has no public ssh key and we're trying to install one: bail
  • Ignore some lines we can't really test
  • Add ordering to some of the relations so it returns stable output
  • Simpler is better
  • In one test run we can't cover both postgresql and other, so ignore all
  • Fix running the tests with the perfplugin but without messing coverage

19 new commits added

  • Make the tests pass on postgresql
  • Fix the docstring
  • fixup: Simplify checking if the priority is in the list of allowed priorities when creating issue
  • Bring the pagure.lib coverage to 100%
  • Adjust the behavior of search_token when not ACLs are specified
  • Drop un-needed check for user_obj
  • Catch all unicode related exceptions in could_be_text()
  • Move the markdown processor convert call to its own function for easier testing
  • Fix searching issues with an offset of 0
  • Fix filtering issues with tags
  • Only announce user's settings change if there was an error
  • Simplify checking if the priority is in the list of allowed priorities when creating issue
  • Fix creating the group when adding it to a project
  • If the user has no public ssh key and we're trying to install one: bail
  • Ignore some lines we can't really test
  • Add ordering to some of the relations so it returns stable output
  • Simpler is better
  • In one test run we can't cover both postgresql and other, so ignore all
  • Fix running the tests with the perfplugin but without messing coverage

Ok tests are now fully passing on postgresql as well as sqlite.

Let's merge thanks for the review @lsedlar ! :)

Pull-Request has been merged by pingou

Metadata