pagure

#2317 Refactor user existence code in API and UI
Merged by pingou. Opened by pingou.
miscfix  into  master

Download 2317.patch

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

rebased

rebased

rebased

Why duplicate this function from pagure/api/user.py? They do seem to raise different exceptions, but it seems that they are both essentially raising a form of 404. I'm not familiar enough with Pagure to know why there are two ways to send 404s…

LGTM.

The API is using some custom error to return JSON even upon exception while the UI uses the more classic flask.abort() which is then processed by a @APP.errorhandler(404) returning a "nice" 404 error page (html).

Thanks for the review! :)

rebased

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.