pagure

#2343 Add ways to customize the gitolite configuration file with snippets
Merged by pingou. Opened by pingou.
custom_gitolite_config  into  master

Download 2343.patch

This commit adds two configuration key, GITOLITE_PRE_CONFIG and
GITOLITE_POST_CONFIG allowing to point to files that will be included
at the top or at the end of the gitolite configuration file.
This allows customizing the gitolite configuration file with elements
or information that are outside of pagure's control.
This can be used in combination with the EXTERNAL_COMMITTER to give
people of certain groups commit access to the git repositories.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

"allows to" => "allows you to"

"customize further" => "further customize"

"and with EXTERNAL_COMMITTER" => ". It can also be used with EXTERNAL_COMMITTER"

"allows to" => "allows you to"

Same as above

I'm wondering if this should return an empty string instead. That way a string is returned either way and then you wouldn't have to have logic elsewhere determining if anything was returned.

It's an idea yes

Why do you have two underscores in the function name instead of one?

This test shouldn't have preconf in it since test_write_gitolite_acls_preconf_postconf should cover that.

There is no "preconf" here. I think you just accidentally swapped the function names of this test and the previous one.

apparently so, thanks for catching it

@pingou, some minor comments, but looks good.

rebased

rebased

Looking further into this, I found that it would introduce empty lines at the top and the end of the file for no real reason and it readability isn't impacted either way, so I'm thinking to leave this as is.

+1

rebased

Thanks for the review!

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.