From bfb40cbb8ecd0e8a290e90357382fe7b465ffda4 Mon Sep 17 00:00:00 2001
From: Pierre-Yves Chibon <pingou@pingoured.fr>
Date: Jun 14 2015 09:00:53 +0000
Subject: [PATCH 1/2] Do not give READ access to everyone on the tickets and pull-requests repo


The tickets repo can contain private information ça we do not want to
expose to everyone, since they are private.
And for the sake of consistency, let's apply the same restriction on
the pull-requests repo.

---

diff --git a/pagure/lib/git.py b/pagure/lib/git.py
index 02383f9..7dd9a1d 100644
--- a/pagure/lib/git.py
+++ b/pagure/lib/git.py
@@ -99,7 +99,8 @@ def write_gitolite_acls(session, configfile):
                     repos = ''
 
             config.append('repo %s%s' % (repos, project.fullname))
-            config.append('  R   = @all')
+            if repos not in ['tickets/', 'requests/']:
+                config.append('  R   = @all')
             if project.groups:
                 config.append('  RW+ = @%s' % ' @'.join([
                     group.group_name for group in project.groups]))

From 7b89d7688cfe76877e03be416bee5bec0d001cef Mon Sep 17 00:00:00 2001
From: Pierre-Yves Chibon <pingou@pingoured.fr>
Date: Jun 15 2015 13:45:39 +0000
Subject: [PATCH 2/2] Adjust the unit-tests for the change


---

diff --git a/tests/test_progit_lib_git.py b/tests/test_progit_lib_git.py
index b4b7f16..1c11aa8 100644
--- a/tests/test_progit_lib_git.py
+++ b/tests/test_progit_lib_git.py
@@ -92,12 +92,10 @@ repo docs/test
   RW+ = foo
 
 repo tickets/test
-  R   = @all
   RW+ = pingou
   RW+ = foo
 
 repo requests/test
-  R   = @all
   RW+ = pingou
   RW+ = foo
 
@@ -110,11 +108,9 @@ repo docs/test2
   RW+ = pingou
 
 repo tickets/test2
-  R   = @all
   RW+ = pingou
 
 repo requests/test2
-  R   = @all
   RW+ = pingou
 
 repo forks/pingou/test3
@@ -126,11 +122,9 @@ repo docs/pingou/test3
   RW+ = pingou
 
 repo tickets/pingou/test3
-  R   = @all
   RW+ = pingou
 
 repo requests/pingou/test3
-  R   = @all
   RW+ = pingou
 
 """
@@ -230,13 +224,11 @@ repo docs/test
   RW+ = foo
 
 repo tickets/test
-  R   = @all
   RW+ = @sysadmin @devs
   RW+ = pingou
   RW+ = foo
 
 repo requests/test
-  R   = @all
   RW+ = @sysadmin @devs
   RW+ = pingou
   RW+ = foo
@@ -250,11 +242,9 @@ repo docs/test2
   RW+ = pingou
 
 repo tickets/test2
-  R   = @all
   RW+ = pingou
 
 repo requests/test2
-  R   = @all
   RW+ = pingou
 
 repo forks/pingou/test2
@@ -266,11 +256,9 @@ repo docs/pingou/test2
   RW+ = pingou
 
 repo tickets/pingou/test2
-  R   = @all
   RW+ = pingou
 
 repo requests/pingou/test2
-  R   = @all
   RW+ = pingou
 
 """