#2538 Add support for a custom user in the SSH URL
Merged by pingou. Opened by pingou.
username_url  into  master

Download 2538.patch

Fixes https://pagure.io/pagure/issue/2524

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

what will happen if you are not logged in?

I thought the block was already not showing but I was mis-reading, fixing

1 new commit added

  • Do not show the SSH url when the user isn't logged in

rebased

@pingou +1. Did you want to change the default config to have {username} in it or document this?

By default no, this is really customed to dist-git.

I'll had a blob to the doc though yes

1 new commit added

  • Document the possibility to customize {username} in the SSH URL

Documented :)

Grammar fix:

If you have a custom setup that requires that all users have an account on the git server, you can use {username} in the URL and it will be expanded to the username of the user viewing the project page.
For example: 'ssh://{username}@pagure.org/'

@pingou, I just realized, can you make this change on the API that shows the git URLs as well? (e.g. https://src.fedoraproject.org/api/0/rpms/fedrepo-req/git/urls)

3 new commits added

  • Document the possibility to customize {username} in the SSH URL
  • Do not show the SSH url when the user isn't logged in
  • Add support for a custom user in the SSH URL

rebased

@pingou +1

Thanks!

Mind doing pagure-dist-git while at it?

Pull-Request has been merged by pingou

Metadata