#2602 Fix loading templates
Merged by pingou. Opened by pingou.
fix_templates  into  master

Download 2602.patch
no initial comment

rebased onto 358a7c5f45387727e1ec26b7963d2473b517f9cf

The intro paragraph claims the project being used in this example is named test. I believe it is more clear if we change this to use that. Otherwise that sentence should be updated to actually say Pagure.

ok, will change to test :)

3 new commits added

  • Adjust the documentation around ticket templates
  • .rstrip() doesn't do what one would think it does, replace with .rsplit()
  • Add namespace support to the get_ticket_template endpoint in the internal API

You could s/, c/. C/

I recommend adding tests, but LGTM otherwise.

4 new commits added

  • Flake8 fix fixing the tests
  • Adjust the documentation around ticket templates
  • .rstrip() doesn't do what one would think it does, replace with .rsplit()
  • Add namespace support to the get_ticket_template endpoint in the internal API

Thanks for the review, there are no tests for this feature atm, I'll see if I can add some and otherwise merge as is.

rebased onto e655b3a967713524e81f150165167765c14cff83

PR rebased and unit-tests added :)

rebased onto c25173ed2cfdcd0d5d893d37608edddf14d10c8f

Pull-Request has been merged by pingou

Metadata