PR#2655: Fix the edit issue endpoint when the user does not actually edit anything - - Pagure.io

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

pagure

#2655 Fix the edit issue endpoint when the user does not actually edit anything

Merged Oct 5, 2017 by pingou. Opened Oct 5, 2017 by pingou.

fix_editing_issue into master

Download 2655.patch

pingou commented Oct 5, 2017

Fixes https://pagure.io/fedora-infrastructure/issue/6389

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

cverna commented Oct 5, 2017

Would messages be None when nothing was edited ? If so it could be if messages is not None

cverna commented Oct 5, 2017

If data is an empty dict, what would happen ?

cverna commented Oct 5, 2017

2 questions, but looks good :thumbsup:

pingou commented Oct 5, 2017

It should be None yes

pingou commented Oct 5, 2017

Wouldn't work, the form validation won't allow it (tested in other tests above)

pingou commented Oct 5, 2017

Thanks! :)

Pull-Request has been merged by pingou

Oct 5, 2017

Metadata

Assignee

None

Tags

No Tags

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.