#2685 Add pagure-admin admin-token update to update the expiration date
Merged by pingou. Opened by pingou.
api_token_expiration  into  master

Download 2685.patch

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

"Invalide" => "Invalid"

Est "invalide" la traudction en français?

It would be good to document the subparser parameter here.

optionnel:
Devrions nous vérifier que la date n'est pas déjà expiré?

data or date? The text says data, but the variable says date.

LGTM

date indeed

hm, good idea yes

Vous pourriez utiliser datetime.strptime(args.date, '%Y-%m-%d').date() au lieu de arrow.

Oui monsieur :)

Small changes but otherwise LGTM.

Fair, though I would still have to get it a timezone as the field in the DB is TZ aware (UTC tz though) and arrow is already a dependency of pagure, so not a new one :)

rebased onto 87a6d077cba3e70136e1b1d33a872b6859e449cd

Adjusted and rebased :)

tests/test_pagure_admin.py is passing, running the entire suite before I merge :)

You should move this out of the try block so the except doesn't catch the PagureException.

Good catch, done :)

1 new commit added

  • Move try/except out fo the block so it gets its own error message

Tests passed \ó/

Pull-Request has been merged by pingou

Metadata