pagure

#2858 Add an alembic revision dropping the pull_request_check constraints
Merged by pingou. Opened by pingou.
drop_constraint  into  master

Download 2858.patch

That constraints is making sure the pull-request is either coming from a
fork or a remote git repository.
Except that when we delete the fork, we still want to keep the
pull-request records, so we can no longer enforce that constraint.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

1 new commit added

  • Flake8 fixes

rebased onto 0cd68a9c91bfd15072e078cf39865cb5de1dee1f

1 new commit added

  • Unit-test fixes due to the milestone links

Would it be an idea to still keep track of the fact that it came originally from a fork?
So maybe add an legacy_fork_fullname name which contains e.g. puiterwijk/pagure?

That sounds like a good idea yes but maybe beyond the scope of 3.13.1

Would you be ok w/ me opening a ticket to trac this request?

rebased onto 310593b20d0b0d65bac6b20fb28837c88d8f3d11

I've adjusted the alembic migration as this constraint was added by another alembic migration, so people who created the DB after that migration likely did not have it...

Okay, +1.

Thanks! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.