Thanks :)

Should we add unit-tests for this?

Yes :)

I think this should be catch by https://pagure.io/pagure/blob/master/f/tests/test_pagure_flask_ui_login.py#_216 but it seems that we are able to test successful login :s

While working on tests for the PR fixing local login, I think I found out that
we aren't testing local login as we should, so more changes to come :)

Ok, if you rebase on the top of #2892 tests should work again for the local login :)

I have changed the local login test, so that we do a successful login (ie redirect to the user home page).

This will not catch issues with the code executed after the fas login though.

This will not catch issues with the code executed after the fas login though.

Is this changing from the current state of things?

This will not catch issues with the code executed after the fas login though.

Is this changing from the current state of things?

No, currently the test suite does not test the fas login, maybe we could do it by using mock. Not sure.

Ok, so if this doesn't change anything on the tests, let's merge :)

+1 :ship: it