pagure

#2895 Move add milestone button to top of issues list
Merged by pingou. Opened by cqi.
cqi/pagure move-add-milestone-button  into  master

Download 2895.patch

Fixes #2860

Signed-off-by: Chenxiong Qi qcxhome@gmail.com

The button no longer works when I try it locally :(

How it doesn't work?

For one, clicking on it has no effect

I have no idea why this happens. I tested this change in my dev env, it works well. Did you test this patch on latest master branch?

I have tested it by checking out the head corresponding to your PR

I rebased this PR and tested it again, both button are entirely inactive for me :(

Using something like

diff --git a/ pagure/templates/issues.html b/ pagure/templates/issues.html
index 20f5e2bf..dd9ebd9d 100644
--- a/pagure/templates/issues.html     
+++ b/pagure/templates/issues.html     
@@ -18,23 +18,23 @@
     {% else %}
       {{ issues|count }} Issues (of {{ issues_cnt }})
     {% endif %}
-    <span class="btn-group btn-group-sm pull-xs-right" role="group">
+    <span class="form-inline pull-xs-right" role="group">
     {% if g.repo_admin %}
-      <a href="javascript:avoid(0)" class="btn btn-secondary btn-sm"
-        data-toggle="modal" data-target="#milestone_modal">
-        Add milestone
-      </a>
+      <a href="javascript:avoid(0)"
+        data-toggle="modal" data-target="#milestone_modal"
+        class="btn btn-secondary" role="button">Add milestone</a>
     {% endif %}
     {% if repo.milestones %}
       <a href="{{ url_for(
           'ui_ns.view_roadmap',
           repo=repo.name,
           username=username,
-          namespace=repo.namespace) }}" class="btn btn-secondary btn-sm">
-        Roadmap
+          namespace=repo.namespace) }}"
+          class="btn btn-secondary" role="button">
+          Roadmap
       </a>
     {% endif %}
-      {% if g.repo.reports %}
+    {% if g.repo.reports %}

makes it work

So debugging this with @cverna last week we found out that the issue occurs if you have the roadmap button, the add new milestone button and the reports button visible.

ping?

I think I got it working in https://pagure.io/pagure/pull-request/3077 if people want to test it :)

Commit 1e2a5f27 fixes this pull-request

Pull-Request has been merged by pingou

@pingou I just came back to my pr and found you had already merged it. Thank you very much. Sorry for not response in time.

@cqi sure thing and no problem :)
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.