Should we make these defaults lists?

One generic question, the rest of the code looks fine.

We'll need some tests for this though :)

Very good point, I'll work on that.

Thanks, for the reivew I'll work on the minor improvement and then also provide some tests.

OTOH I'm not sure how this would work with https://pagure.io/pagure/pull-request/3040#_2,33, which is primarily why I introduced these values... Thoughts?

Phew, so I added the tests.

Thinking more about your note, I'm really starting to think that these values should be just one status, not list of statues, due to the way they're used in the endpoint that flags PRs. Therefore I'd say that this is done, unless you really want these to be lists :)

We would then need defaults for these lists :(

Ok this may just be a bit overkill then, let's start with this and see if we need to tweak more in the future.

I've been using @patch.dict('pagure.config.config', {key: value}) to change the config just for one or a few tests, it saves us the setUp/tearDown approach.