Missing link for EPEL?
indeed
Maybe add a very short sentence like ", the mail filters for postfix"?
Remove the first comma here.
remove the - in set-up and replace with a whitespace.
"If you installed by RPM, "
"if you did not install by RPM, "
It's in the overview already and in the install_milter file as well
"For the sake of this document, we assume that the web application runs under the git user, the same user as ..."
git
I think that it's called "httpd" instead of "httpd", and "apache2" on Debian and derivatives.
"So by default, apache will "
s/facl/file access control lists/
s/Installed/Install/
I don't think systemd is a requirement for this per se right? It's just the default config we ship...
If systemd is the only way to run this, you'll have serious trouble getting adopted by other distros.
Cf the note below :)
Oh, that's explained a bit later.
Sorry :).
Maybe it would be useful to instead remove systemd from the requirements list, and say something like "We ship an example systemd unit file with Pagure. We welcome patches for scripts for other init systems"?
Could be :)
Installing something manually in this directory is, in my opinion, very bad.
I would suggest installing it in /etc/systemd/system instead.
WFM
Maybe clarify that "MTA" is "Message Transfer Agent" and not a "Multimedia terminal adapter" or any of the other things on https://en.wikipedia.org/wiki/MTA ?
Maybe a colon after "wikipedia" but before the link?
I think milter is only supported by sendmail and postfix.
I'm sure at least for these two, don't know for the others
s/you/your/
Wow, this is just awesome to know, thanks!
And very handy when you want to know how your email leaked to spammer (ie: user+website@example.com) and pouf you know that website leaked your email...
mkdir supports a variable number of arguments, no need to get shell-specific with {..} :)
Maybe add the feature that everything is stored in a git repo, and as such it is easy to take your data out?
s/interest/purpose/
s/these/the/
Not sure if history in docs is useful.
s/an/a/
Kinda since it explains why we want to have them on different domain
Yeah, though unfortunately a lot of websites don't support the + in an email address, but I can use "_" on my mail server :)
It's the one I use as well :)
You should use a link to https://en.wikipedia.org/wiki/Message_transfer_agent, or people would have no idea what to pick :)
Maybe call this "Open data"? s/change/changed/
Looks good to me. :crocodile:
Many thanks for the review @puiterwijk