PR#3082: Only run redis once for all tests, preventing leakage of sockets -

pagure

#3082 Only run redis once for all tests, preventing leakage of sockets

Merged Mar 20, 2018 by pingou. Opened Mar 20, 2018 by bkabrda.

bkabrda/pagure test-redis-flushing into master

bkabrda commented Mar 20, 2018

Thanks to this patch, we don't have to reload pagure.lib.tasks and pagure.lib.tasks_services before every test case, so we don't run into the issue where Celery leaks redis connection sockets on disconnecting.

bkabrda commented Mar 20, 2018

FTR, I did run the whole test suite with this and saw no errors except the PEP-8 test failure (which cannot caused by this patch, since this patch only changes a file under tests/)

abompard commented Mar 20, 2018

Looks fine to me, it's similar to what I had come up with :-)

rebased onto 3cb5290aef76a3844501aa561ae80fdafa6238da

Mar 20, 2018

pingou commented Mar 20, 2018

Thanks for this :)

Pull-Request has been merged by pingou

Mar 20, 2018

Metadata

Assignee

None

Tags

No Tags

pagure

#3082 Only run redis once for all tests, preventing leakage of sockets Merged Mar 20, 2018 by pingou. Opened Mar 20, 2018 by bkabrda. bkabrda/pagure test-redis-flushing into master

Metadata

#3082 Only run redis once for all tests, preventing leakage of sockets

Merged Mar 20, 2018 by pingou. Opened Mar 20, 2018 by bkabrda.

bkabrda/pagure test-redis-flushing into master