#3175 Add support for repository templates for sources and forks
Merged by pingou. Opened by pingou.
git_templates  into  master

Download 3175.patch

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

1 new commit added

  • Add a test for creating a git repository with a template

I would make the if explicit here if templ is not None

Well, that wouldn't caught a templ variable set to '', which would be odd granted but..

I'm wondering if we should check if the template path exists and report/ignore if not, what do you think?

endpoint with for --> with is not needed here

:thumbsup:

would it be possible to have some merge conflict here, if the template git repo Readme is quite different ? .

I wonder if we should allow adding the Readme when you use a template.

I'm wondering if we should check if the template path exists and report/ignore if not, what > do you think?

+1

It will create the git repo with the README from the template, then edit and put the new README file and commit it, so there shouldn't be conflict I think.

:thumbsup:

rebased onto 75a89dd03815f11d782a7298934f75a4a975dae9

Pull-Request has been merged by pingou

Metadata