pagure

#3259 Let the reply button append instead of replacing
Merged by pingou. Opened by pingou.
fix_reply  into  master

Download 3259.patch

This ensure that if you have something in the comment area, clicking
on the reply button won't delete it, it will just append the citation
after your text.

Fixes https://pagure.io/pagure/issue/3135

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

rebased onto 4a0b1202b50ee59169679f6b57901981a9209e91

The commit message here is better than #3264, but that one has better code (missing _prev definition here).
Edited by lsedlar

if I start to duplicate my own PRs... time for some vacations maybe? :D

rebased onto b7702821a78d7d62a7ce162b6bcff340ab388f2d

rebased onto 6f5ea090a07fbb052b6deaffc8f2c053eca873d5

Pretty please pagure-ci rebuild

I don't see a new test run for this?

We currently don't have ways to test the JS code.

Any suggestions on how we could do that?

rebased onto e93861900b38ff1baf5578f979cac000ab8e797d

Pretty please pagure-ci rebuild

Code looks okay, but it worries me that Jenkins doesn't come back with "success".

it's still running :) https://ci.centos.org/job/pagure-pr/373/

Build finished but didn't report, let's try again

Pretty please pagure-ci rebuild

Pretty please pagure-ci rebuild

rebased onto edef68d84dd3c1efd04d4dd324593df8f24f684e

rebased onto 7a139bfcf9c89642dc4263f9ddb20a316a0dbd00

Pretty please pagure-ci rebuild

The code change looks good to me (but I didn't test the latest version yet).

For some reason it didn't report the success but the tests did pass https://ci.centos.org/job/pagure-pr/409/

So let's merge :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.