PR#3335: Make _get_project respect CASE_SENSITIVE from settings instead of arg -

pagure

#3335 Make _get_project respect CASE_SENSITIVE from settings instead of arg

Merged Jun 20, 2018 by pingou. Opened Jun 18, 2018 by bkabrda.

bkabrda/pagure case-sensitive-fix into master

Download 3335.patch

bkabrda commented Jun 18, 2018

Fixes #3334

pingou commented Jun 18, 2018

Do we need additional tests?

ngompa commented Jun 18, 2018

:thumbsup:

bkabrda commented Jun 19, 2018

I think there are already tests for this, but I guess I could add a test for case that made me discover this - creating project "foo" and then "FOO" if CASE_SENSITIVE is True. I'll do that later today.

pingou commented Jun 19, 2018

Thanks appreciated :)

rebased onto 1e87ae21fee40466f6c5fd5f8be88ae7c8a4291e

Jun 20, 2018

bkabrda commented Jun 20, 2018

Test case added and rebased on master => ready to merge.

pingou commented Jun 20, 2018

\ó/

Thanks @bkabrda

Pull-Request has been merged by pingou

Jun 20, 2018

Metadata

Assignee

None

Tags

No Tags

pagure

#3335 Make _get_project respect CASE_SENSITIVE from settings instead of arg Merged Jun 20, 2018 by pingou. Opened Jun 18, 2018 by bkabrda. bkabrda/pagure case-sensitive-fix into master

Metadata

#3335 Make _get_project respect CASE_SENSITIVE from settings instead of arg

Merged Jun 20, 2018 by pingou. Opened Jun 18, 2018 by bkabrda.

bkabrda/pagure case-sensitive-fix into master