pagure

#3374 Tweak notification styles
Merged by pingou. Opened by ryanlerch.
ryanlerch/pagure notifications  into  master

Download 3374.patch

Adds all notifications for a single request into a single
box that can be more easily dismissed when there are multiple
notifications. Also absolutely positions the notification so we
don't have to worry about if a page uses a sub-header or not (like
on the repo pages)

The notification body is now white, and the status of each notification
is signifed by the text colour and a small icon.

The welcome message still uses the alert-info colours.

Screenshot_from_2018-06-26_20-02-41.pngScreenshot_from_2018-06-26_20-01-20.pngScreenshot_from_2018-06-26_20-00-15.png

Relates to #3347

Signed-off-by: Ryan Lerch rlerch@redhat.com

rebased onto ec05e152b24a0c913b3d060f6ee01166d00dfeea

Pretty please pagure-ci rebuild

@ryanlerch What happens in a no-JS experience?

And... you need to rebase your code on top of current master. It's failing to do the mergeback to start the test run.

rebased onto 70c221878e597f325e9fc7610f8bad99a161dbba

Pretty please pagure-ci rebuild

Pretty please pagure-ci rebuild

Looks like jenkins is doing something this time :)

Hm, it looks like jenkins aborted the test run but some of the tests didn't pass

rebased onto 6b320d6c6e7d9fe668b8fd438548aaaee806b616

Pretty please pagure-ci rebuild

I didn' t run this code myself, but change itself looks fine and jenkins is happy.

If you are confident about it, go ahead with rebase and merge :)

rebased onto 457592c62e9ef53ef277f5b16b573c25feb3c557

Pretty please pagure-ci rebuild

Thanks @ryanlerch ! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.