PR#3450: Re-generate the sha for every file. -

pagure

#3450 Re-generate the sha for every file.

Merged Jul 23, 2018 by pingou. Opened Jul 20, 2018 by pingou.

fix_checksums into master

pingou commented Jul 20, 2018

Basically, we were instantiating the sha outside of the loop going
through the files. This meant that if we generated the sha for two
files, the sha of the second included the first one in it...

This commit fixes this be making sure we compute a new sha specific
for each file.

Fixes https://pagure.io/pagure/issue/3448

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

rebased onto 28a8734e3a21537f5b80ea7abc124ab7e639deb8

Jul 20, 2018

ngompa commented Jul 21, 2018

:thumbsup:

ignatenkobrain commented Jul 21, 2018

pingou commented Jul 23, 2018

Thanks folks :)

pingou commented Jul 23, 2018

I've worked on adding tests and found a couple of bugs while doing so, but I'll push them to a new PR

Pull-Request has been merged by pingou

Jul 23, 2018

Metadata

Assignee

None

Tags

No Tags

pagure

#3450 Re-generate the sha for every file. Merged Jul 23, 2018 by pingou. Opened Jul 20, 2018 by pingou. fix_checksums into master

Metadata

#3450 Re-generate the sha for every file.

Merged Jul 23, 2018 by pingou. Opened Jul 20, 2018 by pingou.

fix_checksums into master