#3467 Improve packaging
Merged by pingou. Opened by ignatenkobrain.
ignatenkobrain/pagure fedora  into  master

Download 3467.patch
no initial comment
13:29:27   Could not find a version that satisfies the requirement pygit2==0.26.5 (from versions: 0.16.0, 0.16.1, 0.16.2, 0.17.0, 0.17.1, 0.17.2, 0.17.3, 0.18.0, 0.18.1, 0.19.0, 0.19.1, 0.20.0, 0.20.1, 0.20.2, 0.20.3, 0.21.0, 0.21.1, 0.21.2, 0.21.3, 0.21.4, 0.22.0, 0.22.1, 0.23.0, 0.23.1, 0.23.2, 0.23.3, 0.24.0, 0.24.1, 0.24.2, 0.25.0, 0.25.1, 0.26.0, 0.26.1, 0.26.2, 0.26.3, 0.26.4, 0.27.0, 0.27.1)
13:29:27 No matching distribution found for pygit2==0.26.5

Not related to my commit.

Shouldn't this be 0%{?rhel} && 0%{?rhel} <= 7?

We've dropped the explicit trollius dependency in master, since python2-trololio pulls it in anyway, and when we switch to Python 3, we won't use trollius at all.

This is not needed, since this is a celery service. The Requires on the main package is enough.

This is not needed, since this is a celery service. The Requires on the main package is enough.

no, this applies only to el6 and below

oh, you are right!

this is not what requirements.txt say

this is not what requirements-webhook.txt say.

this is not what requirements-webhook.txt say.

@ignatenkobrain I'm not surprised about the requirements-*.txt files. They are still out of sync with the actual requirements for Pagure.

Drop the el6 bit, I don't think pagure will run there anymore.

2 new commits added

  • trollius → trololio
  • drop el6 bits

rebased onto e8ea3dc23943928f7d56093997c2da7b579d7b82

rebased onto e8ea3dc23943928f7d56093997c2da7b579d7b82

this is no longer true, it's required by the pagure core as well

I think it's even python-fedora-flask at the rpm level

Couple of small adjustments, the rest looks good to me :)

rebased onto 92e6a2fbfe6d9e1dbe602911405f9698b9e6e022

Looks good to me, could you rebase? We'll merge it :)

The Python 2 tests are going to fail unless we have something like a requirements-py2.txt that also installs trollius.

rebased onto 5d979b255eb5b6aa07cb466a349ae31011d3eee6

rebased onto e554eca873c6bfc3a963be80825fa35fa85f3767

Commit 689d2fdf fixes this pull-request

Pull-Request has been merged by pingou

Metadata