pagure

#3560 add configure option to restrict email to certain domains
Merged by pingou. Opened by karsten.
karsten/pagure restrict_email_addresses  into  master

Download 3560.patch

fixes #3550
add a config option RESTRICTED_EMAILS which can be used to limit
allowed email addresses to a list of domains.

Signed-off-by: Karsten Hopp karsten@redhat.com

rebased onto b4da711193a9e683c327b7f4c562073c6969085a

What's the idea with this API endpoint?

Doing the validation where users are adding new emails seems sufficient, is it not?

Please rebase on the top of the style_coverage branch which brings some changes to the python style we enforce :)

The idea behind this API endpoint is that users can't see the configuration and have no idea which of their many email accounts they need to use.

The idea behind this API endpoint is that users can't see the configuration and have no idea which of their many email accounts they need to use.

Then why not just tell them in the error message in the UI?

rebased onto 5ab53dc751919691415631e5381dcd6b317ff611

rebased onto ecf11c7aa03ed83992aef3f2cee6bd0c0171d7d7

I've dropped the API part and added the allowed domains to the error message.
I've also renamed the option to 'ALLOWED_EMAIL_DOMAINS'

rebased onto 8720418d0561f7f926910fc7861d4ff7525606de

rebased onto 5c0db639ebbe51b1185d4e8be5d66ed4d3e0b6fb

Looks good to me, waiting on jenkins and we'll merge :)

1 new commit added

  • use @patch to correctly reset config options after the tests

Jenkins is clear, let's merge :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.