#3565 Add a theme for src.fp.o
Merged by pingou. Opened by pingou.
distgit_theme  into  master

Download 3565.patch
  • Fix some indentation in the HTML
  • Adjust the unit-tests for these indentation changes
  • Fix overwriting the templates in the themes
  • Port the template changes from pagure-dist-git into the srcfpo theme

1 new commit added

  • Add a -theme-srcfpo subpackage

rebased onto 5036a98b6d98d598214283b35c4d3f1821d16619

rebased onto e2793985c64317c41353ee1ce6108a53e9af324a

Is there a significant difference between srcfpo and pagureio themes?

Also, does this mean that pagure-dist-git extension is going to be folded into pagure itself?

This needs to be %{python_sitelib} since it gets overridden with the correct Python version at the top.

Otherwise, this looks fine to me.

Is there a significant difference between srcfpo and pagureio themes?

On the layout currently not much but some of the templates are customized.

Also, does this mean that pagure-dist-git extension is going to be folded into pagure itself?

Yes: https://pagure.io/pagure-dist-git/pull-request/59 at least the part about the theming

I'll adjust the spec file, thanks :)

20 new commits added

  • Add the dist-git logo to the srcfpo theme
  • Add a -theme-srcfpo subpackage
  • More indentation fixes in the html
  • Import the userprofile_master template from the default theme into the srcfpo one
  • Add button group linking to the package in other resources
  • Import the repo_info template from the default theme into the srcfpo one
  • More html indentation fixes
  • Override the text on the front page when logged out
  • Start working on a theme for src.fp.o
  • Fix link in the drop-down for members
  • Indentation fixes
  • Fix overriding templates in the theme
  • Grey out branches when they are retired
  • Fixes the unit-tests for the changes in the HTML
  • Fix link to the koschei icon
  • Import the repo_branches template from the default theme into the srcfpo one
  • Adjustment to the html indentation
  • Customize the userprofile_master template for the srcfpo one
  • Add package description and upstream's URL to the page
  • Add a banner about adding a README file when PRs are disabled

Thanks for the review @ngompa :)

Pull-Request has been merged by pingou

Metadata