pagure

#3597 Fix the PR 'to' dropdown to actually toggle the correct dropdown
Merged by ryanlerch. Opened by bkabrda.
bkabrda/pagure fix-pr-to-dropdown  into  master

Download 3597.patch

Without this, both the buttons trigger the "from" dropdown, which leads to confusing behavior and it actually makes it impossible to select the "to" branch.

Hmm, wait, this actually also needs to be solved in pagure/templates/repo_pull_request.html - I'll amend this PR.

Ah, no, I was wrong, everything seems to be working fine now, ready for review.

@bkabrda just wondering if you can give a bit more info on the issue this solves, and/or some steps to reproduce. I can't seem to re-create the issue here on my system...

@ryanlerch when you go on the page where you're supposed to provide name and description for the new pull request, there are two dropdowns for branches: from and to. Without this PR, the "to" dropdown seems to display, but it is actually the "from", so if you click that, it will change the "to", not "from" (the original repo must have at least two branches to reproduce this).

:thumbsup:

LGTM!

Pull-Request has been merged by ryanlerch
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.