pagure

#3604 populate PR dropdown-menu when PR button is clicked, not upon page load
Merged by ryanlerch. Opened by karsten.
karsten/pagure optimize_PR_ready  into  master

Download 3604.patch

fixes #3599
every page related to a git repository has a pull-request button that
opens a dropdown-menu. This menu is populated when the page loads, even
when creating a PR might not be the intention of visiting that page.

Signed-off-by: Karsten Hopp karsten@redhat.com

:thumbsup:

+1 from me on doing this, but I'd also like to see doing the computations of the internal endpoint result in worker rather than in server - the instance of Pagure that I run has repos that have dozens of branches and doing this can occupy a single server thread for seconds.

I'll work on moving the diff calculation to worker tasks and will do a new PR for that. But in meantime I'd like to have this in pagure to lessen the load on the server as right now loading any project page will trigger those calculations .

@karsten +1, sounds great. Thanks!

rebased onto 79e42ffcd736516a0c616651630b60970a4dc406

LGTM.

@bkabrda @karsten should we file an issue on getting the backend part of this moved from server to worker as well?

Otherwise, once rebased, is this one right to merge?

rebased onto 57bb57a1752fd5a311f5fb502da65b646693e6be

rebased onto bcd6a2b0a0deb29e0883c4fe61e37d4c27a75463

rebased onto 57bb57a1752fd5a311f5fb502da65b646693e6be

rebased onto 045c5cd839d83a5b706e3587c8c4fe9d95db06ea

pls merge if it looks good to you

Pull-Request has been merged by ryanlerch
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.