pagure

#3608 fix re match after black changes
Merged by pingou. Opened by karsten.
karsten/pagure black_fix  into  master

Download 3608.patch

The version can not be parsed anymore after the black fixes where " got changed to ', docs generation doesn't work.

Signed-off-by: Karsten Hopp karsten@redhat.com

Won't this just change it back again?

No. The black change was in pagure/init.py and now the regular expression to find the version didn't match anymore.

markdown: pagure/__init__.py

I'm sorry, I mean when the codebase is blackened again, won't it just break it again?

I say this because you've swapped to single quote strings here, which I think black takes an issue to.

1 new commit added

  • use double quotes everywhere

:thumbsup:

after a rebase, is this one right to merge?

rebased onto 19722be74f7d7bf833c8d61793395bce39f65cf9

I think it is, but I shouldn't review my own PR :smile:
It is easy to test, though when you have all the requirements installed:
cd doc; make singlehtml

if it immediately fails with "AttributeError: 'NoneType' object has no attribute 'group'" it isn't fixed

Thanks! :)

rebased onto 3ace6470f72fb3feb60bf63c03188db9aafdce9a

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.